Skip to content

Add support for Kyria v1.4 with Adafruit KB2040 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

janlindblom
Copy link

See title, this PR adds support for Kyria with the Adafruit KB2040 controller. Cannot verify for Blok controllers since I don't have any of those...

Full support for RGB underglow and OLED display, although the corner approach in Peg limits the useful area of the OLED display to basically 128x32 or less since there is no easy way to reach the rest of the display as the extension in kmk_firmware is structured right now.

@kwmlodozeniec
Copy link
Contributor

Please remove .vscode settings folder, editor setting should not be included in repositories as editors are a personal choice.

Copy link
Collaborator

@daysgobye daysgobye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I uber appreciate you PRing this board in, its a very popular split. I like all the work you did I want to see 2 changes before I merge this pr.

  1. remove the .vscode folder
  2. it looks like your main.py's are not made by peg. contibuting docs I am only being difficult about this because peg parsees this python code and it can have unexpected results when its not formatting correctly. So I would like to see the leds, keymap, and oleds be the code output by peg.

@janlindblom
Copy link
Author

janlindblom commented Oct 6, 2022

Thanks @daysgobye I'll take care of those!

Edit: @daysgobye , is there a way to do load and export the main.py without physically plugging in a board? I'm tinkering with my KB2040's so they're running motor control for a tricopter at the moment...

@kdb424
Copy link
Contributor

kdb424 commented Oct 9, 2022

The libs zipped up may be a problem unless peg knows how to handle that. I've moved that board to quickpin in core KMK as well, and opened up #30 here to add quickpin to most boards. Once that is merged, this should likely be updated to reflect that change as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants