-
Notifications
You must be signed in to change notification settings - Fork 24
Add support for Kyria v1.4 with Adafruit KB2040 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for Kyria v1.4 with Adafruit KB2040 #7
Conversation
… manages to not hang.
…t Kyria logo on the right OLED.
Please remove .vscode settings folder, editor setting should not be included in repositories as editors are a personal choice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey I uber appreciate you PRing this board in, its a very popular split. I like all the work you did I want to see 2 changes before I merge this pr.
- remove the .vscode folder
- it looks like your main.py's are not made by peg. contibuting docs I am only being difficult about this because peg parsees this python code and it can have unexpected results when its not formatting correctly. So I would like to see the leds, keymap, and oleds be the code output by peg.
Thanks @daysgobye I'll take care of those! Edit: @daysgobye , is there a way to do load and export the |
The libs zipped up may be a problem unless peg knows how to handle that. I've moved that board to quickpin in core KMK as well, and opened up #30 here to add quickpin to most boards. Once that is merged, this should likely be updated to reflect that change as well. |
See title, this PR adds support for Kyria with the Adafruit KB2040 controller. Cannot verify for Blok controllers since I don't have any of those...
Full support for RGB underglow and OLED display, although the corner approach in Peg limits the useful area of the OLED display to basically 128x32 or less since there is no easy way to reach the rest of the display as the extension in kmk_firmware is structured right now.