Skip to content

refactor(manager): retire project work on worktree removal - #226

Merged
boadij merged 2 commits into
mainfrom
refactor/herdr-project-retirement
Oct 2, 2026
Merged

boadij merged 2 commits into
mainfrom
refactor/herdr-project-retirement

Conversation

@boadij

@boadij boadij commented Oct 2, 2026

Copy link
Copy Markdown
Owner

Fixes #225

Summary

  • Retire only the matching project assignment and retained messages after an authoritative Herdr linked-worktree removal.
  • Keep missing-worktree recovery nonterminal and preserve the Git branch.
  • Remove Manager completion/discard controls superseded by worktree removal.

Validation

  • Focused tests passed for Herdr, controller API, commands, extension contract, and smoke runner.
  • npm run check: 805 passed, 1 skipped, 0 failed.
  • npm run build and npm run package:audit passed.
  • npm run smoke -- manager-recovery: scenario and cleanup passed.
  • git diff --check passed.

@boadij

boadij commented Oct 2, 2026 •

Copy link
Copy Markdown
Owner Author

External Review #1 follow-up is pushed in 0ceb99552e4357b701fcb665940d364cc498cf06.

  • Removed the Manager/currentManager and session-ID gate: any eligible same-repository observer may retire only on authoritative Herdr removal. Repository/scope checks, both locks, and the expected-assignment-ID guard remain.
  • Made the test socket portable: Windows uses a named pipe; Unix uses a short temporary socket path with cleanup in finally.
  • Validation: focused controller test passed (95 tests); npm run check passed (805 passed, 1 skipped); npm run build passed; npm run package:audit passed (55 files); fresh manager-recovery smoke scenario and cleanup passed; git diff --check passed.

@boadij
boadij force-pushed the refactor/herdr-project-retirement branch from 0ceb995 to 623844c Compare October 2, 2026 15:00
@boadij

boadij commented Oct 2, 2026 •

Copy link
Copy Markdown
Owner Author

External Review #2 is resolved on rebased head 623844c756046c736cff84801be1675a436ce464.

Validation on the rebased head: npm run check passed (805 passed, 1 skipped); build and package:audit passed (55 files); git diff --check passed; focused tests passed (337 across commands, controller-api, extension-contract, herdr, and smoke-runner). The fresh manager-recovery smoke scenario and cleanup both passed. Final prettier . --write made no changes, and post-format check/diff-check passed.

@boadij
boadij merged commit ad403ad into main Oct 2, 2026
7 checks passed
@boadij
boadij deleted the refactor/herdr-project-retirement branch October 2, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(manager): retire project work on worktree removal

1 participant