Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump temporal_rs version and update changelog #76

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jul 7, 2024

This PR bumps the version in the changelog and bumps the Cargo.toml version to 0.0.3 for release

@jedel1043
Copy link
Member

jedel1043 commented Jul 7, 2024

Was thinking that we should probably exclude dependabot updates from git cliff
EDIT: Is there an option to exclude users in the cliff config file?

@nekevss
Copy link
Member Author

nekevss commented Jul 7, 2024

Potentially? it does look like we may be able to group the CHANGELOG.md better if we used conventional commits.

EDIT: So currently it now filters out any commit that is "^Bump", but I think we could configure "dependabot"'s commit message to use conventional commits, something like "chore(dependency): ",which may be better overall.

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#commit-message

* Migrate parsing to `ixdtf` crate by @nekevss in [#50](https://github.com/boa-dev/temporal/pull/50)
* Bump `icu_calendar` to 1.5 by @jedel1043 in [#47](https://github.com/boa-dev/temporal/pull/47)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, this was excluded under the "^Bump" rule, which may not be the best approach.

@jedel1043
Copy link
Member

EDIT: So currently it now filters out any commit that is "^Bump", but I think we could configure "dependabot"'s commit message to use conventional commits, something like "chore(dependency): ",which may be better overall.

Makes sense. We can add that on a separate PR I think.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog looks good to me!

@nekevss nekevss merged commit 234387b into main Jul 8, 2024
5 checks passed
nekevss added a commit that referenced this pull request Jul 9, 2024
As mentioned in #76, this should hopefully allow us to filter bot
commits from future changelogs.
@nekevss nekevss deleted the generate-v0.0.3-changelog branch July 9, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants