Skip to content

Should PlainTime and PlainDateTime have from_signed_fields methods #432

Open

Description

@nekevss

Note: this doesn't necessarily have to be called from_signed_fields.

Currently, the ECMAScript constructors can be called with integer values.

This means it is entirely possible that a PlainTime may be called with negative values that need to be rejected. In order to best preserve specification compliance, we should have something that allows passing the integer field values, even if the negative values will be rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-apiChanges related to the public API

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions