-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Symbol hash to u64
#911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
enhancement
New feature or request
builtins
PRs and Issues related to builtins/intrinsics
execution
Issues or PRs related to code execution
labels
Oct 23, 2020
RageKnify
approved these changes
Oct 23, 2020
Test262 conformance changes:
|
Codecov Report
@@ Coverage Diff @@
## master #911 +/- ##
=======================================
Coverage 59.19% 59.19%
=======================================
Files 166 166
Lines 10512 10512
=======================================
Hits 6223 6223
Misses 4289 4289
Continue to review full report at Codecov.
|
Benchmark for fd692acClick to view benchmark
|
jasonwilliams
approved these changes
Oct 23, 2020
Razican
approved these changes
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builtins
PRs and Issues related to builtins/intrinsics
enhancement
New feature or request
execution
Issues or PRs related to code execution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes the following:
18_446_744_073_709_551_616
even if we crated a symbol every1ns
it would take584
years (so... pretty much will never overflow)