fix(profiler): update profiler to match current measureme api #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moves all OS profiling to use SerializationSink as the previous types have been deprecated Closes #839
Codecov Report
@@ Coverage Diff @@
## master #840 +/- ##
=======================================
Coverage 59.37% 59.37%
=======================================
Files 157 157
Lines 10036 10036
=======================================
Hits 5959 5959
Misses 4077 4077
Continue to review full report at Codecov.
|
Lan2u
approved these changes
Oct 11, 2020
|
Should we add a check in the CI to make sure this works? |
|
Yeah sure, I guess we just need to ensure the profiler is able to execute with no errors on some JS file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves all OS profiling to use SerializationSink as the previous types
have been deprecated
Closes #839