Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calling "new" on a primitive value throw a type error #825

Merged
merged 2 commits into from
Oct 9, 2020
Merged

calling "new" on a primitive value throw a type error #825

merged 2 commits into from
Oct 9, 2020

Conversation

dlemel8
Copy link
Contributor

@dlemel8 dlemel8 commented Oct 8, 2020

This Pull Request fixes/closes #801.

@HalidOdat HalidOdat added bug Something isn't working execution Issues or PRs related to code execution labels Oct 8, 2020
@HalidOdat HalidOdat added this to the v0.11.0 milestone Oct 8, 2020
Razican
Razican approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@HalidOdat HalidOdat merged commit b26f8bc into boa-dev:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Razican approved these changes

Assignees
No one assigned
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Calling "new" on a primitive value does not throw an error
3 participants
@dlemel8 @Razican @HalidOdat