Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move exec implementations together with AST node structs #735

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Move exec implementations together with AST node structs #735

merged 3 commits into from
Oct 2, 2020

Conversation

georgeroman
Copy link
Contributor

Fixes #721

It changes the following:

  • Moved Executable implementations for nodes in the same files as node declarations
  • Broke down some files (ast/node/declaration.rs, ast/node/iteration.rs, ...) into multiple files (one per node)

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #735 into master will not change coverage.
The diff coverage is 67.64%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #735   +/-   ##
=======================================
  Coverage   71.89%   71.89%           
=======================================
  Files         200      195    -5     
  Lines       14014    14014           
=======================================
  Hits        10076    10076           
  Misses       3938     3938           
Impacted Files Coverage Δ
boa/src/exec/mod.rs 57.14% <ø> (-28.28%) ⬇️
boa/src/syntax/ast/node/break_node/tests.rs 100.00% <ø> (ø)
boa/src/syntax/ast/node/iteration/tests.rs 100.00% <ø> (ø)
boa/src/syntax/ast/node/operator/tests.rs 100.00% <ø> (ø)
boa/src/syntax/ast/node/switch/tests.rs 100.00% <ø> (ø)
boa/src/syntax/ast/node/try_node/tests.rs 100.00% <ø> (ø)
boa/src/syntax/ast/node/object/mod.rs 37.14% <43.75%> (ø)
...src/syntax/ast/node/iteration/do_while_loop/mod.rs 47.72% <47.72%> (ø)
boa/src/syntax/ast/node/statement_list/mod.rs 48.71% <60.00%> (ø)
...c/syntax/ast/node/declaration/let_decl_list/mod.rs 60.52% <60.52%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a1296...9df6899. Read the comment docs.

@HalidOdat HalidOdat added enhancement New feature or request execution Issues or PRs related to code execution labels Oct 1, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Oct 1, 2020
@georgeroman
Copy link
Contributor Author

Can I ask for a faster review on this? As a lot of files were moved, it's hard to always fix conflicts and keep this PR in sync.

@georgeroman
Copy link
Contributor Author

Looks like an unrelated CI fail (https://github.com/boa-dev/boa/pull/735/checks?check_run_id=1198128772).

@RageKnify RageKnify modified the milestones: v0.10.0, v0.11.0 Oct 2, 2020
@RageKnify RageKnify merged commit 767a8cc into boa-dev:master Oct 2, 2020
@georgeroman georgeroman deleted the move_exec_to_ast branch October 2, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move executable implementations with the rest of the struct impl
3 participants