-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed console
s dependency of InternalState
#544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
performance
Performance related changes and issues
builtins
PRs and Issues related to builtins/intrinsics
labels
Jul 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
==========================================
+ Coverage 68.33% 68.45% +0.11%
==========================================
Files 172 172
Lines 10495 10476 -19
==========================================
- Hits 7172 7171 -1
+ Misses 3323 3305 -18
Continue to review full report at Codecov.
|
Benchmark for 1cedd27Click to view benchmark
|
Benchmark for d5eaa80Click to view benchmark
|
jasonwilliams
approved these changes
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builtins
PRs and Issues related to builtins/intrinsics
performance
Performance related changes and issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem this the previous implementation?
The problem with keeping the state of
console
in a internal state is that for every a call toconsole
s methods we had to first unwrap it. which is not performant also keeping the state in means that when the methods are bound to the object itself an will panic if not state was provided, for example:This Pull Request also fixes/closes #426 by removing
print
as it is not a part of spec.