Fix: boa_cli returns non-zero exit code on uncaught exceptions#5345
Closed
Pantkartik wants to merge 1 commit into
Closed
Fix: boa_cli returns non-zero exit code on uncaught exceptions#5345Pantkartik wants to merge 1 commit into
Pantkartik wants to merge 1 commit into
Conversation
github-actions
Bot
added
Waiting On Review
Member
|
Duplicate of #4964 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Currently, the boa CLI returns an exit code of 0 even when a script fails with an uncaught runtime exception. This PR modifies evaluate_file and evaluate_expr in cli/src/main.rs to propagate errors back to the main function, ensuring a non-zero exit code is returned on failure.
Fixes: #4962
Verification:
Verified that boa returns exit code 1 for scripts with uncaught errors.
Verified that successful scripts still return exit code 0.