Fix TextDecoder to respect DataView byteOffset and byteLength#4815
Closed
shreyadesai20042009 wants to merge 9 commits into
Closed
Fix TextDecoder to respect DataView byteOffset and byteLength#4815shreyadesai20042009 wants to merge 9 commits into
shreyadesai20042009 wants to merge 9 commits into
Conversation
zhuzhu81998
reviewed
Mar 2, 2026
zhuzhu81998
left a comment
zhuzhu81998
left a comment
Contributor
There was a problem hiding this comment.
this needs to wait until #4787 is merged.
| )); | ||
| JsArrayBuffer::from_object(obj)? | ||
| } | ||
| // ✅ FIXED: Handle DataView properly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4767
This change ensures that TextDecoder.decode correctly respects
the byteOffset and byteLength of DataView objects.
Previously, DataView inputs were decoded using the full
underlying ArrayBuffer instead of the specified view range.
Now the decoder properly slices the buffer before decoding.