String wasn't defaulting to empty when called as String() with no arg… #407

jasonwilliams · 2020-05-20T21:48:25Z

The tests for this are in https://github.com/jasonwilliams/boa/pull/396 and it should unblock that PR also

…ument

github-actions · 2020-05-20T22:06:10Z

Benchmark for `7e5cfaa`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
Create Realm	402.0±24.20µs	395.3±15.15µs	102%
Expression (Lexer)	1911.8±88.42ns	2.0±0.11µs	93%
Expression (Parser)	5.1±0.19µs	5.0±0.26µs	101%
Fibonacci (Execution)	2.9±0.11ms	2.9±0.13ms	100%
For loop (Execution)	420.3±18.35µs	454.4±21.31µs	92%
For loop (Lexer)	5.1±0.22µs	5.1±0.25µs	98%
For loop (Parser)	14.5±0.60µs	14.3±0.67µs	102%
Hello World (Lexer)	960.5±42.92ns	1009.7±44.07ns	95%
Hello World (Parser)	2.4±0.10µs	2.4±0.13µs	100%
Symbols (Execution)	435.2±18.86µs	435.1±16.91µs	100%
	undefined	undefined	100%

String wasn't defaulting to empty when called as String() with no arg…

41a9ff6

…ument

jasonwilliams force-pushed the fix_default_values branch from ca615dd to 41a9ff6 Compare May 20, 2020 21:51

jasonwilliams mentioned this pull request May 20, 2020

Corrected impl of typeof #396

Merged

jasonwilliams merged commit 05f220d into master May 20, 2020

Razican added the bug Something isn't working label May 21, 2020

Razican added this to the v0.8.0 milestone May 21, 2020

HalidOdat deleted the fix_default_values branch May 31, 2020 22:34