Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some string optimizations #4030

Merged
merged 12 commits into from
Nov 11, 2024
Merged

Some string optimizations #4030

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
dbd47ad
chore: replace `js_str` with `js_string`
CrazyboyQCD Nov 6, 2024
7961777
chore: replace `boolean`'s `to_string` with literal
CrazyboyQCD Nov 6, 2024
d287dc6
chore: remove unnecessary `to_string`
CrazyboyQCD Nov 6, 2024
a84e045
chore: fix lint and format
CrazyboyQCD Nov 6, 2024
5c29f69
chore: add feature gate to import `js_str`
CrazyboyQCD Nov 8, 2024
0101695
chore: change `get_typed_fn`'s name to `JsString`
CrazyboyQCD Nov 8, 2024
3a74312
chore: replace js_str with js_string(cli)
CrazyboyQCD Nov 8, 2024
f49ac91
chore: replace js_str with js_string(`try_into_js`)
CrazyboyQCD Nov 8, 2024
d2e6cb9
chore: replace js_str with js_string(`Console`)
CrazyboyQCD Nov 8, 2024
8e5a080
chore: fix lint
CrazyboyQCD Nov 8, 2024
9f1574e
perf: use more efficient `LazyLock` on `RAW_STATICS_CACHE`
CrazyboyQCD Nov 8, 2024
1bfe1ef
chore: move `js_str` together with other imports
CrazyboyQCD Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove unnecessary to_string
  • Loading branch information
@CrazyboyQCD
CrazyboyQCD committed Nov 6, 2024
commit d287dc65e8fe34faba0a581c9e2dd8fabfd716a8
2 changes: 1 addition & 1 deletion core/engine/src/builtins/number/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ impl Number {
#[allow(clippy::wrong_self_convention)]
pub(crate) fn to_js_string(x: f64) -> JsString {
let mut buffer = ryu_js::Buffer::new();
js_string!(buffer.format(x).to_string())
js_string!(buffer.format(x))
}

/// `Number.prototype.toString( [radix] )`
Expand Down
Loading