Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console.debug() should use a debug Logger method #4019

Merged
merged 1 commit into from
Nov 2, 2024
Merged

console.debug() should use a debug Logger method #4019

merged 1 commit into from
Nov 2, 2024

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Oct 14, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.85%. Comparing base (6ddc2b4) to head (8d186a3).
Report is 278 commits behind head on main.

Files with missing lines Patch % Lines
core/runtime/src/console/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4019      +/-   ##
==========================================
+ Coverage   47.24%   52.85%   +5.60%     
==========================================
  Files         476      482       +6     
  Lines       46892    46723     -169     
==========================================
+ Hits        22154    24694    +2540     
+ Misses      24738    22029    -2709

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jedel1043
jedel1043 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedel1043 jedel1043 added API enhancement New feature or request labels Oct 14, 2024
@jedel1043 jedel1043 added this to the next-release milestone Oct 14, 2024
@jedel1043 jedel1043 requested a review from a team October 14, 2024 20:20
jasonwilliams
jasonwilliams approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonwilliams jasonwilliams added this pull request to the merge queue Nov 2, 2024
Merged via the queue into boa-dev:main with commit d3dbb4a Nov 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@jasonwilliams jasonwilliams jasonwilliams approved these changes

Assignees
No one assigned
Labels
API enhancement New feature or request
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hansl @jasonwilliams @jedel1043