Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to the console Logger trait #4005

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Sep 24, 2024

This is not backward compatible but should have minimal impact. This is also more future proof by passing the ConsoleState which is more opaque and allows us to update the way the console object is constructed and passed.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 18.36735% with 40 lines in your changes missing coverage. Please review.

Project coverage is 52.78%. Comparing base (6ddc2b4) to head (3da1bde).
Report is 266 commits behind head on main.

Files with missing lines Patch % Lines
core/runtime/src/console/mod.rs 18.36% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4005      +/-   ##
==========================================
+ Coverage   47.24%   52.78%   +5.53%     
==========================================
  Files         476      480       +4     
  Lines       46892    46676     -216     
==========================================
+ Hits        22154    24636    +2482     
+ Misses      24738    22040    -2698     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is not backward compatible but should have minimal impact.
This is also more future proof by passing the ConsoleState
which is more opaque and allows us to update the way the
console object is constructed and passed.
@hansl hansl force-pushed the console-add-context branch from 605f138 to 3da1bde Compare September 24, 2024 19:27
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat requested a review from a team September 24, 2024 22:14
@jedel1043 jedel1043 added enhancement New feature or request API labels Sep 24, 2024
@jedel1043 jedel1043 added this to the next-release milestone Sep 24, 2024
@HalidOdat HalidOdat added this pull request to the merge queue Sep 24, 2024
Merged via the queue into boa-dev:main with commit e6a6950 Sep 24, 2024
14 checks passed
@hansl hansl deleted the console-add-context branch September 25, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants