Fix js_str macro to correctly handle latin1 strings
#3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was checking it out and came to the same fix, but you beat me to it 😆 |
HalidOdat
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Maybe we should also include the test that @hansl had in #3958, besides that this looks perfect to me! :)
EDIT: nvm just saw the comment: #3958 (comment)
Test262 conformance changes
|
jedel1043
force-pushed
the
fix-js-str-latin1
branch
from
3a964e7 to
067577d
Compare
jasonwilliams
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3958.