-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a custom Logger to be used as the backend for boa_runtime::Console #3943
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3943 +/- ##
==========================================
+ Coverage 47.24% 51.44% +4.19%
==========================================
Files 476 468 -8
Lines 46892 45168 -1724
==========================================
+ Hits 22154 23235 +1081
+ Misses 24738 21933 -2805 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (apart from comment), thanks @hansl
I made the change, PTAL. Sorry I asked for a re-review from @jedel1043 by mistake. |
There are some cleanup that could be done in the number of lines of codes, but this was the smallest change I could do to make the change.
This comes from a need to implement
Console
with usingtracing
as the backend. Please note that there is an issue here where multiple logs in the same function (e.g.console.trace()
) would output into multiple log entries. This should probably be fixed in a following PR (as this one is already large enough).