Add more utility functions around modules and exports #3937
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3937 +/- ##
==========================================
+ Coverage 47.24% 51.62% +4.37%
==========================================
Files 476 468 -8
Lines 46892 44999 -1893
==========================================
+ Hits 22154 23230 +1076
+ Misses 24738 21769 -2969 ☔ View full report in Codecov by Sentry. |
core/engine/src/module/mod.rs
Outdated
| /// This combines two operations that are often done together into a simpler | ||
| /// version. If you need more control over the execution, use [`load_link_evaluate`] | ||
| /// and [`Context::run_jobs`] separately. | ||
| pub fn load_link_evaluate_and_run_jobs(&self, context: &mut Context) -> JsResult<()> { |
There was a problem hiding this comment.
Maybe it's time to find a better name for the original function. load_link_evaluate sounds a bit spec-y and I think something like run would also be fine. That would also make the name of this function a lot shorter; run_blocking or something like that.
There was a problem hiding this comment.
eval_blocking? Either way I can make the change in this PR.
There was a problem hiding this comment.
Though about something. I think people would also want to await other promises, so maybe it should be better to add an await_ method to JsPromise? That sidesteps the need for a new method for the module, and you would just call
module.load_link_resolve(context).await_(context)?
| #[derive(Debug, Clone, Trace, Finalize)] | ||
| pub struct TypedJsFunction<A: TryIntoJsArguments, R: TryFromJs> { | ||
| inner: JsFunction, | ||
| _args: PhantomData<A>, | ||
| _ret: PhantomData<R>, | ||
| } |
There was a problem hiding this comment.
Loving this new API! It should help for strictness in many ways.
This allows to create a moderately simple example (see
tests/gcd.rs) that can be used as a tutorial.There are some typing issues, notably the
nameargument inget_typed_fn. Let's discuss.