Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix destructuring assignment evaluation order #3934

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix destructuring assignment evaluation order #3934

merged 1 commit into from
Jul 23, 2024

Conversation

raskad
Copy link
Member

@raskad raskad commented Jul 23, 2024

This PR changes the following:

  • Fix evaluation of computed property names in declaration patterns
  • Fix invalid value getter in iterator opcode
  • Fix invalid setting of function binding identifier in global_declaration_instantiation

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Jul 23, 2024
@raskad raskad added this to the next-release milestone Jul 23, 2024
@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 48,212 48,212 0
Passed 43,262 43,264 +2
Ignored 1,413 1,413 0
Failed 3,537 3,535 -2
Panics 0 0 0
Conformance 89.73% 89.74% +0.00%
Fixed tests (2): 
test/language/expressions/assignment/destructuring/keyed-destructuring-property-reference-target-evaluation-order.js (previously Failed)
test/language/expressions/assignment/destructuring/iterator-destructuring-property-reference-target-evaluation-order.js (previously Failed)

@raskad raskad requested a review from a team July 23, 2024 00:37
HalidOdat
HalidOdat approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@HalidOdat HalidOdat requested a review from a team July 23, 2024 03:45
@nekevss nekevss added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit e205b56 Jul 23, 2024
13 checks passed
@raskad raskad deleted the fix-destr-assignment-iter branch July 23, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @HalidOdat @nekevss