Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Instant for new Temporal functionality #3928

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jul 19, 2024

Continued work on Temporal 😄

It changes the following:

  • Adds static method implementations
  • Bump temporal_rs rev
  • implement to_temporal_instant

Copy link

Test262 conformance changes

Test result main count PR count difference
Total 48,212 48,212 0
Passed 43,151 43,229 +78
Ignored 1,413 1,413 0
Failed 3,648 3,570 -78
Panics 0 0 0
Conformance 89.50% 89.66% +0.16%
Fixed tests (78):
test/built-ins/Temporal/Instant/compare/argument-string-with-offset-not-valid-epoch-nanoseconds.js (previously Failed)
test/built-ins/Temporal/Instant/compare/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/Instant/compare/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/Instant/compare/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/Instant/compare/name.js (previously Failed)
test/built-ins/Temporal/Instant/compare/instant-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/Instant/compare/exhaustive.js (previously Failed)
test/built-ins/Temporal/Instant/compare/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/Instant/compare/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/Instant/compare/instant-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/Instant/compare/prop-desc.js (previously Failed)
test/built-ins/Temporal/Instant/compare/builtin.js (previously Failed)
test/built-ins/Temporal/Instant/fromEpochNanoseconds/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/Instant/fromEpochNanoseconds/name.js (previously Failed)
test/built-ins/Temporal/Instant/fromEpochNanoseconds/length.js (previously Failed)
test/built-ins/Temporal/Instant/fromEpochNanoseconds/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/Instant/fromEpochNanoseconds/prop-desc.js (previously Failed)
test/built-ins/Temporal/Instant/fromEpochNanoseconds/builtin.js (previously Failed)
test/built-ins/Temporal/Instant/from/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/Instant/from/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/Instant/from/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/Instant/from/name.js (previously Failed)
test/built-ins/Temporal/Instant/from/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/Instant/from/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/Instant/from/length.js (previously Failed)
test/built-ins/Temporal/Instant/from/instant-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/Instant/from/prop-desc.js (previously Failed)
test/built-ins/Temporal/Instant/from/builtin.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/largestunit-wrong-type.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/roundingincrement-nan.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/roundingmode-invalid-string.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/largestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/smallestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/roundingincrement-out-of-range.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/options-undefined.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-ceil.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/largestunit-wrong-type.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-halfFloor.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-halfEven.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/roundingincrement-nan.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/largestunit-undefined.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-halfExpand.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-halfTrunc.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-invalid-string.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/smallestunit-undefined.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/options-object.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/largestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/roundingincrement-undefined.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-expand.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-halfCeil.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-floor.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/round-cross-unit-boundary.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/instant-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/smallestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/roundingincrement-out-of-range.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/add/argument-string.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/equals/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/equals/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/equals/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/equals/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/equals/instant-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/equals/instant-string.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/round/smallestunit-string-shorthand.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/round/smallestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/subtract/argument-string.js (previously Failed)
test/built-ins/Temporal/Instant/fromEpochMilliseconds/basic.js (previously Failed)
test/built-ins/Temporal/Instant/fromEpochMilliseconds/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/Instant/fromEpochMilliseconds/name.js (previously Failed)
test/built-ins/Temporal/Instant/fromEpochMilliseconds/length.js (previously Failed)
test/built-ins/Temporal/Instant/fromEpochMilliseconds/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/Instant/fromEpochMilliseconds/prop-desc.js (previously Failed)
test/built-ins/Temporal/Instant/fromEpochMilliseconds/builtin.js (previously Failed)

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jedel1043 jedel1043 requested a review from a team July 19, 2024 16:03
@jedel1043 jedel1043 added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Jul 19, 2024
@jedel1043 jedel1043 added this to the next-release milestone Jul 19, 2024
@raskad raskad added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 523bdd0 Jul 19, 2024
13 checks passed
@jedel1043 jedel1043 deleted the update-temporal-instant branch July 19, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants