-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Icu
API
#3503
Simplify Icu
API
#3503
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3503 +/- ##
==========================================
- Coverage 49.01% 48.99% -0.02%
==========================================
Files 469 469
Lines 48186 48192 +6
==========================================
- Hits 23618 23613 -5
- Misses 24568 24579 +11 ☔ View full report in Codecov by Sentry. |
Test262 conformance changes
|
6ccb43b
to
3e11ef1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it needs a rebase. But everything else looks good to me!
e6b9081
to
a9ae59f
Compare
Hides
BoaProvider
to be crate-private, which makes the overall API easier for users.