-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporal duration update and cleanup #3443
Conversation
e5d679b
to
53aef84
Compare
Test262 conformance changes
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3443 +/- ##
==========================================
- Coverage 44.82% 44.81% -0.02%
==========================================
Files 488 488
Lines 50497 50373 -124
==========================================
- Hits 22637 22576 -61
+ Misses 27860 27797 -63
☔ View full report in Codecov by Sentry. |
Smaller PRs sound like the best way to work incrementally on temporal, so +1 to that. |
I'll try to do more frequent smaller updates then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some minor nitpick! :)
53aef84
to
67c8b28
Compare
67c8b28
to
81bda2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Some more work on
temporal
, in a little bit of a smaller PR 😉Mostly just trying to do a bit of cleanup and small cleanups/refactors with the idea of beginning to migrate some of the temporal methods and structures into their own crates.
It changes the following:
Temporal.Duration
's methods and abstracts to relatively recent changes to the specification.Aside: are smaller PRs a bit more similar to this one going to be easier to manage even if they are relatively more unfinished? I'm trying to avoid the monstrosity that was the last PR.