Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal duration update and cleanup #3443

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Oct 31, 2023

Some more work on temporal, in a little bit of a smaller PR 😉

Mostly just trying to do a bit of cleanup and small cleanups/refactors with the idea of beginning to migrate some of the temporal methods and structures into their own crates.

It changes the following:

  • Updates and/or begins to update a couple of Temporal.Duration's methods and abstracts to relatively recent changes to the specification.
  • General nitpicky cleanups to begin isolating some Temporal APIs from Boa specifics (calendar impl's needing context)

Aside: are smaller PRs a bit more similar to this one going to be easier to manage even if they are relatively more unfinished? I'm trying to avoid the monstrosity that was the last PR.

@nekevss nekevss force-pushed the temporal-cleanup-one branch from e5d679b to 53aef84 Compare October 31, 2023 03:25
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 76,518 76,518 0
Ignored 18,132 18,132 0
Failed 959 959 0
Panics 0 0 0
Conformance 80.03% 80.03% 0.00%

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 444 lines in your changes are missing coverage. Please review.

Comparison is base (04ed7be) 44.82% compared to head (81bda2e) 44.81%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3443      +/-   ##
==========================================
- Coverage   44.82%   44.81%   -0.02%     
==========================================
  Files         488      488              
  Lines       50497    50373     -124     
==========================================
- Hits        22637    22576      -61     
+ Misses      27860    27797      -63     
Files Coverage Δ
boa_engine/src/builtins/temporal/mod.rs 26.78% <ø> (ø)
boa_engine/src/builtins/temporal/instant/mod.rs 12.14% <0.00%> (-0.08%) ⬇️
boa_engine/src/builtins/temporal/fields.rs 0.00% <0.00%> (ø)
boa_engine/src/builtins/temporal/plain_date/iso.rs 8.23% <0.00%> (+0.09%) ⬆️
boa_engine/src/builtins/temporal/duration/mod.rs 39.09% <0.00%> (+5.10%) ⬆️
boa_engine/src/builtins/temporal/plain_date/mod.rs 36.18% <0.00%> (-3.82%) ⬇️
boa_engine/src/builtins/temporal/calendar/iso.rs 10.40% <18.60%> (+0.91%) ⬆️
boa_engine/src/builtins/temporal/calendar/mod.rs 10.52% <7.14%> (-0.07%) ⬇️
...oa_engine/src/builtins/temporal/duration/record.rs 8.92% <0.00%> (+0.13%) ⬆️

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss requested a review from a team October 31, 2023 04:09
@nekevss nekevss added the builtins PRs and Issues related to builtins/intrinsics label Oct 31, 2023
@jedel1043
Copy link
Member

Smaller PRs sound like the best way to work incrementally on temporal, so +1 to that.

@nekevss
Copy link
Member Author

nekevss commented Nov 1, 2023

I'll try to do more frequent smaller updates then.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor nitpick! :)

boa_engine/src/builtins/temporal/calendar/mod.rs Outdated Show resolved Hide resolved
@nekevss nekevss force-pushed the temporal-cleanup-one branch from 53aef84 to 67c8b28 Compare November 3, 2023 02:10
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jedel1043 jedel1043 added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit 34d5c51 Nov 4, 2023
14 checks passed
ahaoboy pushed a commit to ahaoboy/boa that referenced this pull request Nov 15, 2023
ahaoboy pushed a commit to ahaoboy/boa that referenced this pull request Nov 15, 2023
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
@raskad raskad deleted the temporal-cleanup-one branch December 5, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants