-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move FunctionKind
to CodeBlock
#3440
Conversation
Test262 conformance changes
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3440 +/- ##
==========================================
+ Coverage 45.39% 45.45% +0.05%
==========================================
Files 483 483
Lines 49787 49715 -72
==========================================
- Hits 22602 22599 -3
+ Misses 27185 27116 -69
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice refactor!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic! 😄 Really nice refactor!
1d1e441
to
62f2f25
Compare
* Move `FunctionKind` flag to CodeBlock * Add `IS_ARROW` flag to codeblock * Remove GetAsyncArrowFunction and GetFunctionAsync opcodes * Remove GetGeneratorAsync opcode
* Move `FunctionKind` flag to CodeBlock * Add `IS_ARROW` flag to codeblock * Remove GetAsyncArrowFunction and GetFunctionAsync opcodes * Remove GetGeneratorAsync opcode
* Move `FunctionKind` flag to CodeBlock * Add `IS_ARROW` flag to codeblock * Remove GetAsyncArrowFunction and GetFunctionAsync opcodes * Remove GetGeneratorAsync opcode
Depends on #3439
Since the kind of the function is known at compile time, we can move it to
CodeBlock
's bitflags. This change allows us to simplify the logic of function creation. RemoveGetAsyncArrowFunction
,GetFunctionAsync
andGetGeneratorAsync
opcodes.