Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the array-grouping proposal #3420

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Implement the array-grouping proposal #3420

merged 1 commit into from
Oct 25, 2023

Conversation

jedel1043
Copy link
Member

Two simple additions to the builtins: Object.groupBy and Map.groupBy.

@jedel1043 jedel1043 added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Oct 25, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Oct 25, 2023
@jedel1043 jedel1043 requested a review from a team October 25, 2023 10:05
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 75,926 75,978 +52
Ignored 18,924 18,872 -52
Failed 759 759 0
Panics 0 0 0
Conformance 79.41% 79.47% +0.05%
Fixed tests (52):
test/built-ins/Map/groupBy/groupLength.js [strict mode] (previously Ignored)
test/built-ins/Map/groupBy/groupLength.js (previously Ignored)
test/built-ins/Map/groupBy/length.js [strict mode] (previously Ignored)
test/built-ins/Map/groupBy/length.js (previously Ignored)
test/built-ins/Map/groupBy/negativeZero.js [strict mode] (previously Ignored)
test/built-ins/Map/groupBy/negativeZero.js (previously Ignored)
test/built-ins/Map/groupBy/emptyList.js [strict mode] (previously Ignored)
test/built-ins/Map/groupBy/emptyList.js (previously Ignored)
test/built-ins/Map/groupBy/iterator-next-throws.js [strict mode] (previously Ignored)
test/built-ins/Map/groupBy/iterator-next-throws.js (previously Ignored)
test/built-ins/Map/groupBy/callback-throws.js [strict mode] (previously Ignored)
test/built-ins/Map/groupBy/callback-throws.js (previously Ignored)
test/built-ins/Map/groupBy/map-instance.js [strict mode] (previously Ignored)
test/built-ins/Map/groupBy/map-instance.js (previously Ignored)
test/built-ins/Map/groupBy/callback-arg.js [strict mode] (previously Ignored)
test/built-ins/Map/groupBy/callback-arg.js (previously Ignored)
test/built-ins/Map/groupBy/invalid-iterable.js [strict mode] (previously Ignored)
test/built-ins/Map/groupBy/invalid-iterable.js (previously Ignored)
test/built-ins/Map/groupBy/invalid-callback.js [strict mode] (previously Ignored)
test/built-ins/Map/groupBy/invalid-callback.js (previously Ignored)
test/built-ins/Map/groupBy/evenOdd.js [strict mode] (previously Ignored)
test/built-ins/Map/groupBy/evenOdd.js (previously Ignored)
test/built-ins/Map/groupBy/name.js [strict mode] (previously Ignored)
test/built-ins/Map/groupBy/name.js (previously Ignored)
test/built-ins/Map/groupBy/toPropertyKey.js [strict mode] (previously Ignored)
test/built-ins/Map/groupBy/toPropertyKey.js (previously Ignored)
test/built-ins/Object/groupBy/groupLength.js [strict mode] (previously Ignored)
test/built-ins/Object/groupBy/groupLength.js (previously Ignored)
test/built-ins/Object/groupBy/length.js [strict mode] (previously Ignored)
test/built-ins/Object/groupBy/length.js (previously Ignored)
test/built-ins/Object/groupBy/emptyList.js [strict mode] (previously Ignored)
test/built-ins/Object/groupBy/emptyList.js (previously Ignored)
test/built-ins/Object/groupBy/iterator-next-throws.js [strict mode] (previously Ignored)
test/built-ins/Object/groupBy/iterator-next-throws.js (previously Ignored)
test/built-ins/Object/groupBy/callback-throws.js [strict mode] (previously Ignored)
test/built-ins/Object/groupBy/callback-throws.js (previously Ignored)
test/built-ins/Object/groupBy/callback-arg.js [strict mode] (previously Ignored)
test/built-ins/Object/groupBy/callback-arg.js (previously Ignored)
test/built-ins/Object/groupBy/invalid-iterable.js [strict mode] (previously Ignored)
test/built-ins/Object/groupBy/invalid-iterable.js (previously Ignored)
test/built-ins/Object/groupBy/null-prototype.js [strict mode] (previously Ignored)
test/built-ins/Object/groupBy/null-prototype.js (previously Ignored)
test/built-ins/Object/groupBy/invalid-callback.js [strict mode] (previously Ignored)
test/built-ins/Object/groupBy/invalid-callback.js (previously Ignored)
test/built-ins/Object/groupBy/evenOdd.js [strict mode] (previously Ignored)
test/built-ins/Object/groupBy/evenOdd.js (previously Ignored)
test/built-ins/Object/groupBy/name.js [strict mode] (previously Ignored)
test/built-ins/Object/groupBy/name.js (previously Ignored)
test/built-ins/Object/groupBy/invalid-property-key.js [strict mode] (previously Ignored)
test/built-ins/Object/groupBy/invalid-property-key.js (previously Ignored)
test/built-ins/Object/groupBy/toPropertyKey.js [strict mode] (previously Ignored)
test/built-ins/Object/groupBy/toPropertyKey.js (previously Ignored)

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (808a08a) 45.45% compared to head (973e0b0) 45.40%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3420      +/-   ##
==========================================
- Coverage   45.45%   45.40%   -0.06%     
==========================================
  Files         483      483              
  Lines       49743    49808      +65     
==========================================
+ Hits        22613    22615       +2     
- Misses      27130    27193      +63     
Files Coverage Δ
boa_engine/src/builtins/object/mod.rs 59.29% <12.50%> (-3.75%) ⬇️
boa_engine/src/builtins/map/mod.rs 65.65% <8.33%> (-12.88%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@raskad raskad added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 1fa7eb5 Oct 25, 2023
14 checks passed
@jedel1043 jedel1043 deleted the array-grouping branch October 25, 2023 21:23
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants