Implement Atomics builtin
#3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3394 +/- ##
==========================================
- Coverage 45.45% 44.82% -0.63%
==========================================
Files 483 488 +5
Lines 49715 50497 +782
==========================================
+ Hits 22599 22637 +38
- Misses 27116 27860 +744
☔ View full report in Codecov by Sentry. |
Test262 conformance changes
Fixed tests (540): |
jedel1043
changed the title
Atomics builtinAtomics builtin
HalidOdat
reviewed
Oct 28, 2023
There was a problem hiding this comment.
Really nice work @jedel1043!
Still have some parts to review, have some small nitpicks :)
Closed
raskad
approved these changes
Oct 31, 2023
ahaoboy
pushed a commit
to ahaoboy/boa
that referenced
this pull request
Nov 15, 2023
ahaoboy
pushed a commit
to ahaoboy/boa
that referenced
this pull request
Nov 15, 2023
sam-finch-tezos
pushed a commit
to trilitech/boa
that referenced
this pull request
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
Atomicsobject (excludingAtomics.waitAsync, because thread-safe async timers are hard 😭), and implements the required glue code inboa_testerto run the related tests.The implementation is mostly based on V8's, but thanks to the
intrusive-collectionscrate, we didn't need to handle too much unsafe code related to doubly linked lists.Will try to add documentation about how exactly everything works, but I'm opening this for reviews on the implementation.Documented everything, including the futex algorithm. Hopefully this makes it a bit easier to understand!