-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update feature flags to specific feature flag #3376
Conversation
Test262 conformance changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3376 +/- ##
==========================================
- Coverage 47.10% 46.05% -1.05%
==========================================
Files 474 474
Lines 48737 48737
==========================================
- Hits 22956 22448 -508
- Misses 25781 26289 +508
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need the granularity of promise-resolvers
. For temporal
is understandable because we're planning to gate every builtin behind a feature, but additions to existing builtins can exist in experimental
since they're simpler APIs.
ead41a2
to
f13d464
Compare
Just for the record, I do think we need a mechanism to enable experimental features individually. However, I think this can be accomplished in a backwards compatible way by using directives instead of Rust features. This would be pretty similar to how Rust handles nightly features:
|
This Pull Request addresses the feature flag discussion from #3277.
It changes the following:
temporal
andpromise-resolvers
feature flag