Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Context::create_realm #3369

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add Context::create_realm #3369

merged 1 commit into from
Oct 16, 2023

Conversation

johnyob
Copy link
Contributor

@johnyob johnyob commented Oct 9, 2023

This Pull Request fixes/closes issue described in this discord thread.

It changes the following:

  • Provides a function for creating Realms with the default global bindings.

@HalidOdat HalidOdat added enhancement New feature or request API labels Oct 10, 2023
@HalidOdat HalidOdat requested a review from a team October 10, 2023 12:51
@johnyob johnyob force-pushed the ajob410@create-realm-with-default-globals branch from f44e897 to c5efb41 Compare October 11, 2023 09:05
@johnyob johnyob changed the title Add Realm::create_with_default_global_bindings Add Context::create_realm Oct 11, 2023
jedel1043
jedel1043 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I think the new API could be used in boa_tester for the createRealm function, but we can leave it as a future improvement for now.

@jedel1043 jedel1043 added this to the v0.18.0 milestone Oct 11, 2023
@jedel1043 jedel1043 requested a review from a team October 11, 2023 09:12
HalidOdat
HalidOdat reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the clippy warning, this looks perfect to me! :)

boa_engine/src/builtins/mod.rs Outdated Show resolved Hide resolved
@johnyob
Add Context::create_realm.
9f4e504 
Provides a function for creating Realms with the default global bindings.
@johnyob johnyob force-pushed the ajob410@create-realm-with-default-globals branch from c5efb41 to 9f4e504 Compare October 16, 2023 12:48
@HalidOdat HalidOdat enabled auto-merge October 16, 2023 13:47
@HalidOdat HalidOdat added this pull request to the merge queue Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (348c757) 49.55% compared to head (9f4e504) 45.71%.
Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3369      +/-   ##
==========================================
- Coverage   49.55%   45.71%   -3.84%     
==========================================
  Files         446      482      +36     
  Lines       43705    49182    +5477     
==========================================
+ Hits        21656    22485     +829     
- Misses      22049    26697    +4648
Files Coverage Δ
boa_engine/src/context/mod.rs 51.97% <0.00%> (-0.95%) ⬇️

... and 90 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into boa-dev:main with commit b6ff658 Oct 16, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
API enhancement New feature or request
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@johnyob @HalidOdat @jedel1043