Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class inherit from null #3312

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fix class inherit from null #3312

merged 1 commit into from
Sep 26, 2023

Conversation

HalidOdat
Copy link
Member

Fixes class inheritance from null, which was causing this test262 test to fail: test/language/statements/class/subclass/class-definition-null-proto-this.js

@HalidOdat HalidOdat added bug Something isn't working execution Issues or PRs related to code execution labels Sep 26, 2023
@HalidOdat HalidOdat added this to the v0.18.0 milestone Sep 26, 2023
@HalidOdat HalidOdat requested a review from a team September 26, 2023 18:02
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,165 75,167 +2
Ignored 19,494 19,494 0
Failed 915 913 -2
Panics 0 0 0
Conformance 78.65% 78.65% +0.00%
Fixed tests (2):
test/language/statements/class/subclass/class-definition-null-proto-this.js [strict mode] (previously Failed)
test/language/statements/class/subclass/class-definition-null-proto-this.js (previously Failed)

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (25c120b) 49.80% compared to head (721e5db) 49.79%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3312      +/-   ##
==========================================
- Coverage   49.80%   49.79%   -0.01%     
==========================================
  Files         441      441              
  Lines       43078    43083       +5     
==========================================
- Hits        21456    21455       -1     
- Misses      21622    21628       +6     
Files Coverage Δ
boa_engine/src/vm/opcode/mod.rs 7.03% <ø> (ø)
boa_engine/src/vm/opcode/set/class_prototype.rs 93.93% <ø> (ø)
boa_engine/src/vm/opcode/push/class/mod.rs 74.07% <84.21%> (+10.07%) ⬆️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@raskad raskad added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 60c9583 Sep 26, 2023
10 checks passed
@HalidOdat HalidOdat deleted the fix/class-inherit-from-null branch September 26, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants