-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve bytecompiler bytecode generation. #3188
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3188 +/- ##
==========================================
- Coverage 50.40% 50.38% -0.02%
==========================================
Files 436 436
Lines 42375 42432 +57
==========================================
+ Hits 21358 21381 +23
- Misses 21017 21051 +34
|
I like the refactor, but there seems to be a bug somewhere since -1,820 tests are failing |
d606744
to
5e0d134
Compare
Test262 conformance changes
|
5e0d134
to
3b192d1
Compare
3b192d1
to
15e5dc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor!
This PR adds the
Operand
enum (which represents an instruction operand), and makesByteCompiler::emit
take an array ofOperand
s instead ofu32
which allows to emit varying length operands more easily.