Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement String.prototype.isWellFormed and String.prototype.toWellFormed #3187

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented Jul 30, 2023

This Pull Request changes the following:

  • Implement String.prototype.isWellFormed and String.prototype.toWellFormed

@raskad raskad added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Jul 30, 2023
@raskad raskad added this to the v0.18.0 milestone Jul 30, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,260 95,260 0
Passed 74,952 74,984 +32
Ignored 19,230 19,198 -32
Failed 1,078 1,078 0
Panics 0 0 0
Conformance 78.68% 78.72% +0.03%
Fixed tests (32):
test/built-ins/String/prototype/toWellFormed/not-a-constructor.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/toWellFormed/not-a-constructor.js (previously Ignored)
test/built-ins/String/prototype/toWellFormed/return-abrupt-from-this.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/toWellFormed/return-abrupt-from-this.js (previously Ignored)
test/built-ins/String/prototype/toWellFormed/length.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/toWellFormed/length.js (previously Ignored)
test/built-ins/String/prototype/toWellFormed/to-string-primitive.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/toWellFormed/to-string-primitive.js (previously Ignored)
test/built-ins/String/prototype/toWellFormed/to-string.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/toWellFormed/to-string.js (previously Ignored)
test/built-ins/String/prototype/toWellFormed/name.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/toWellFormed/name.js (previously Ignored)
test/built-ins/String/prototype/toWellFormed/prop-desc.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/toWellFormed/prop-desc.js (previously Ignored)
test/built-ins/String/prototype/toWellFormed/returns-well-formed-string.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/toWellFormed/returns-well-formed-string.js (previously Ignored)
test/built-ins/String/prototype/isWellFormed/not-a-constructor.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/isWellFormed/not-a-constructor.js (previously Ignored)
test/built-ins/String/prototype/isWellFormed/return-abrupt-from-this.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/isWellFormed/return-abrupt-from-this.js (previously Ignored)
test/built-ins/String/prototype/isWellFormed/length.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/isWellFormed/length.js (previously Ignored)
test/built-ins/String/prototype/isWellFormed/to-string-primitive.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/isWellFormed/to-string-primitive.js (previously Ignored)
test/built-ins/String/prototype/isWellFormed/returns-boolean.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/isWellFormed/returns-boolean.js (previously Ignored)
test/built-ins/String/prototype/isWellFormed/to-string.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/isWellFormed/to-string.js (previously Ignored)
test/built-ins/String/prototype/isWellFormed/name.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/isWellFormed/name.js (previously Ignored)
test/built-ins/String/prototype/isWellFormed/prop-desc.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/isWellFormed/prop-desc.js (previously Ignored)

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #3187 (5e471ad) into main (2b01ef1) will decrease coverage by 0.02%.
The diff coverage is 11.76%.

@@            Coverage Diff             @@
##             main    #3187      +/-   ##
==========================================
- Coverage   50.41%   50.39%   -0.02%     
==========================================
  Files         436      436              
  Lines       42343    42360      +17     
==========================================
+ Hits        21346    21348       +2     
- Misses      20997    21012      +15     
Files Changed Coverage Δ
boa_engine/src/builtins/string/mod.rs 56.02% <11.76%> (-0.94%) ⬇️

@raskad raskad requested a review from a team July 30, 2023 17:23
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat requested a review from a team July 30, 2023 17:57
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nekevss nekevss added this pull request to the merge queue Jul 30, 2023
Merged via the queue into main with commit 4f9175b Jul 30, 2023
@raskad raskad deleted the string-well-formed branch July 30, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants