Add missing 'unscopables' to Array.prototype[@@unscopables]

[dirkdev98]

This also includes the variants for toSorted, toSpliced and toReversed even though they are not implemented yet. This doesn't have any effect on the runtime since with is not implemented to use Symbol.unscopables.

[dirkdev98]

Test262 conformance changes

Test result	main count	PR count	difference
Total	94,858	94,858	0
Passed	74,691	74,693	+2
Ignored	18,828	18,828	0
Failed	1,339	1,337	-2
Panics	0	0	0
Conformance	78.74%	78.74%	+0.00%

Fixed tests (2):

test/built-ins/Array/prototype/Symbol.unscopables/array-find-from-last.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/Symbol.unscopables/array-find-from-last.js (previously Failed)

[codecov]

Codecov Report

Merging #3111 (76f8dd1) into main (9b1f2f4) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3111      +/-   ##
==========================================
+ Coverage   50.42%   50.67%   +0.25%     
==========================================
  Files         444      444              
  Lines       45877    42621    -3256     
==========================================
- Hits        23132    21599    -1533     
+ Misses      22745    21022    -1723     

Impacted Files	Coverage Δ
boa_engine/src/builtins/array/mod.rs	76.32% <100.00%> (-0.76%)	⬇️

... and 187 files with indirect coverage changes

[jedel1043]

Haven't forgot about reviewing this :)

We just have to investigate the regressions first, but the PR looks great!

[Razican]

Haven't forgot about reviewing this :)

We just have to investigate the regressions first, but the PR looks great!

It seems that the regressions are previous false positives, since I can also see them fail in #3094, which doesn't seem related.

[dirkdev98]

No worries!

We just have to investigate the regressions first, but the PR looks great!

I assume you mean the failing test/intl402/ListFormat/constructor/constructor/locales-valid.js test262 test right?
Is there an issue or discussion somewhere about this already or should I create one?

[dirkdev98]

I added the comment with test conformance changes based on a local result.

cargo run --release --bin boa_tester -- run -v -o ./local/changes
./target/release/boa_tester compare ../boa-gh-pages/test262/refs/heads/main/latest.json ./local/changes/latest.json  -m

where boa-gh-pages is the latest gh-pages branch.

CI seems to be fine https://github.com/boa-dev/boa/actions/runs/5468021068/jobs/9955094733#step:11:80. So something is up for me locally. I'll clean my environment and try to figure out whats going on and create an issue separately with local details when I can reproduce it afterwards.

[jedel1043]

Since the regressions seem to be unrelated, we can merge this. Thanks!

[HalidOdat]

Looks good to me! :)

[dirkdev98]

Thanks for the reviews ;)