Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy ABOUT.md file to all published crates #3074

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

jedel1043
Copy link
Member

Unfortunately, cargo publish cannot handle having relative paths to files outside of the published crate, which is why we need to undo the change. Left the individual files though, since it makes it easier to check for diffs at least.

Thought about using symlinks instead, but it seems that support for symlinks in git on windows is still suboptimal.

@jedel1043 jedel1043 added bug Something isn't working documentation update documentation labels Jun 26, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Jun 26, 2023
@jedel1043 jedel1043 requested a review from a team June 26, 2023 23:21
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,842 94,842 0
Passed 74,691 74,691 0
Ignored 18,812 18,812 0
Failed 1,339 1,339 0
Panics 0 0 0
Conformance 78.75% 78.75% 0.00%

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3074 (b383964) into main (e96c838) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3074   +/-   ##
=======================================
  Coverage   50.43%   50.43%           
=======================================
  Files         445      445           
  Lines       45910    45910           
=======================================
  Hits        23154    23154           
  Misses      22756    22756           
Impacted Files Coverage Δ
boa_ast/src/lib.rs 75.00% <ø> (ø)
boa_cli/src/main.rs 0.60% <ø> (ø)
boa_engine/src/lib.rs 78.20% <ø> (ø)
boa_gc/src/lib.rs 99.51% <ø> (ø)
boa_icu_provider/src/lib.rs 100.00% <ø> (ø)
boa_interner/src/lib.rs 84.03% <ø> (ø)
boa_macros/src/lib.rs 0.00% <ø> (ø)
boa_profiler/src/lib.rs 66.66% <ø> (ø)
boa_tester/src/main.rs 0.00% <ø> (ø)
boa_unicode/src/lib.rs 66.66% <ø> (ø)
... and 1 more

@HalidOdat HalidOdat added this pull request to the merge queue Jun 27, 2023
Merged via the queue into main with commit 551a287 Jun 27, 2023
@jedel1043 jedel1043 deleted the fix-about-md-publish branch June 27, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants