Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow JobQueue to concurrently run jobs #3036

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Allow JobQueue to concurrently run jobs #3036

merged 2 commits into from
Jun 13, 2023

Conversation

jedel1043
Copy link
Member

This change allows implementors of JobQueue to concurrently run the pending jobs with some other runtime logic they're running in their app.
Will also become useful to add features to boa_runtime.

@jedel1043 jedel1043 added enhancement New feature or request execution Issues or PRs related to code execution API labels Jun 12, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Jun 12, 2023
@jedel1043 jedel1043 requested a review from a team June 12, 2023 20:14
@github-actions
Copy link

github-actions bot commented Jun 12, 2023 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 94,108 94,108 0
Passed 74,670 74,670 0
Ignored 17,740 17,740 0
Failed 1,698 1,698 0
Panics 0 0 0
Conformance 79.35% 79.35% 0.00%

@codecov
Copy link

codecov bot commented Jun 12, 2023 •
edited
Loading

Codecov Report

Merging #3036 (b1a6b32) into main (827c055) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3036      +/-   ##
==========================================
- Coverage   50.56%   50.55%   -0.01%     
==========================================
  Files         446      446              
  Lines       45982    45987       +5     
==========================================
  Hits        23251    23251              
- Misses      22731    22736       +5
Impacted Files Coverage Δ
boa_engine/src/context/mod.rs 57.56% <0.00%> (-0.65%) ⬇️
boa_engine/src/job.rs 52.63% <0.00%> (-1.92%) ⬇️

HalidOdat
HalidOdat approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! :)

@Razican Razican enabled auto-merge June 13, 2023 22:29
@Razican Razican added this pull request to the merge queue Jun 13, 2023
Razican
Razican approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Merged via the queue into main with commit 0e1b32a Jun 13, 2023
@jedel1043 jedel1043 deleted the run-jobs-async branch June 13, 2023 23:02
Razican pushed a commit that referenced this pull request Jun 26, 2023
@jedel1043 @Razican
Allow JobQueue to concurrently run jobs (#3036)
acc1fd5 
* Allow `JobQueue` to concurrently run jobs

* Remove bounds on `run_jobs_async`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Razican approved these changes

Assignees
No one assigned
Labels
API enhancement New feature or request execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jedel1043 @Razican @HalidOdat