-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SyntaxErrors in GlobalDeclarationInstantiation #2908
Conversation
Test262 conformance changes
Fixed tests (10):
|
Codecov Report
@@ Coverage Diff @@
## main #2908 +/- ##
==========================================
- Coverage 51.82% 51.81% -0.02%
==========================================
Files 431 431
Lines 43302 43369 +67
==========================================
+ Hits 22443 22473 +30
- Misses 20859 20896 +37
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looking good! Just had a small nitpick with an error message
This Pull Request changes the following:
Early
phase inboa_tester
.parse
to theruntime
phase inboa_tester
.