Prevent allocation of field names #2901
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
CodeBlock
storeJsString
s in thenames
field instead ofIdentifier
(which is a wrapper aroundSym
), This is done because once we resolve thesym
and get the&[u16]
we allocate aJsString
on every field access in the worst case and at best if it's part of the static strings array we do aHashMap
lookup.Ran the benchmarks locally and there was a
2%
to10%
increase in performance in some of the benchmarks.The performance increase can be better seen by running the
quickjs
benches:Main
PR