-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Refactor guards into a ContextCleanupGuard
abstraction
#2890
Conversation
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2890 +/- ##
==========================================
+ Coverage 51.23% 51.24% +0.01%
==========================================
Files 427 427
Lines 42520 42528 +8
==========================================
+ Hits 21786 21795 +9
+ Misses 20734 20733 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor! Looks good to me! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes a lot of sense and makes eval code a lot safer to adjust.
bors r+ |
Noticed we were using this pattern on a couple of places, so I abstracted it behind a `ContextCleanupGuard` struct. Let me know if you remember another place where this pattern would apply.
Pull request successfully merged into main. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
ContextCleanupGuard
abstractionContextCleanupGuard
abstraction
Noticed we were using this pattern on a couple of places, so I abstracted it behind a
ContextCleanupGuard
struct.Let me know if you remember another place where this pattern would apply.