[Merged by Bors] - Fix more Annex B tests

[jedel1043]

This Pull Request fixes some additional Annex B tests.

It changes the following:

• Fixes bugs related to parsing HTML closing comments (-->).
• Implements RegExp::compile behind the annex-b feature.
• Ignores the legacy-regexp feature flag, since it's still stage 3.

[github-actions]

Test262 conformance changes

Test result	main count	PR count	difference
Total	94,591	94,591	0
Passed	71,630	71,670	+40
Ignored	17,634	17,686	+52
Failed	5,327	5,235	-92
Panics	0	0	0
Conformance	75.73%	75.77%	+0.04%

Fixed tests (42):

test/annexB/built-ins/Function/createdynfn-no-line-terminator-html-close-comment-body.js [strict mode] (previously Failed)
test/annexB/built-ins/Function/createdynfn-no-line-terminator-html-close-comment-body.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/Symbol.split/toint32-limit-recompiles-source.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/Symbol.split/toint32-limit-recompiles-source.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/flags-to-string.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/flags-to-string.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-to-string-err.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-to-string-err.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-undefined.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-undefined.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-regexp-flags-defined.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-regexp-flags-defined.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-regexp-immutable-lastindex.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-regexp-immutable-lastindex.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/B.RegExp.prototype.compile.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/B.RegExp.prototype.compile.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-regexp-distinct.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-regexp-distinct.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-string.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-string.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/this-obj-not-regexp.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/this-obj-not-regexp.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/flags-to-string-err.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/flags-to-string-err.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/this-not-object.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/this-not-object.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/name.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/name.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/flags-undefined.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/flags-undefined.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/length.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/length.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-regexp-props.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-regexp-props.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-regexp-same.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-regexp-same.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/flags/order-after-compile.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/flags/order-after-compile.js (previously Failed)
test/annexB/language/comments/multi-line-html-close.js [strict mode] (previously Failed)
test/annexB/language/comments/multi-line-html-close.js (previously Failed)
test/annexB/language/comments/single-line-html-close.js [strict mode] (previously Failed)
test/annexB/language/comments/single-line-html-close.js (previously Failed)

[codecov]

Codecov Report

Merging #2841 (539da3e) into main (d288b63) will decrease coverage by 0.03%.
The diff coverage is 43.75%.

@@            Coverage Diff             @@
##             main    #2841      +/-   ##
==========================================
- Coverage   51.38%   51.36%   -0.03%     
==========================================
  Files         417      417              
  Lines       41328    41349      +21     
==========================================
- Hits        21238    21237       -1     
- Misses      20090    20112      +22     

Impacted Files	Coverage Δ
boa_engine/src/builtins/regexp/mod.rs	64.28% <20.58%> (-2.75%)	⬇️
boa_engine/src/builtins/function/mod.rs	39.95% <100.00%> (+0.44%)	⬆️
boa_engine/src/string/mod.rs	74.44% <100.00%> (ø)
boa_parser/src/lexer/mod.rs	79.31% <100.00%> (-0.29%)	⬇️
boa_parser/src/lexer/regex.rs	61.34% <100.00%> (+1.69%)	⬆️
boa_parser/src/parser/cursor/buffered_lexer/mod.rs	84.52% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[HalidOdat]

Looks good to me! :)

[raskad]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• Build and Test (macos-latest)
• Build and Test (windows-latest)
• Coverage
• Misc