[Merged by Bors] - Allow passing owned HostHooks and JobQueues to Context
#2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2811 +/- ##
==========================================
- Coverage 51.31% 51.11% -0.21%
==========================================
Files 416 417 +1
Lines 41213 41517 +304
==========================================
+ Hits 21149 21221 +72
- Misses 20064 20296 +232
... and 25 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Razican
approved these changes
Apr 12, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 12, 2023
This allows `thread_local` contexts to have owned `HostHooks` and `JobQueues`. It changes the following: - Creates a new `MaybeShared` struct that can hold either a reference or an `Rc`. - Changes the `job_queue` and `host_hooks` parameters of `Context` to use `MaybeShared`. This PR also allows us to make `SimpleJobQueue` the default promise runner, which I think it's pretty cool :) cc @lastmjs
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
HostHooks and JobQueues to ContextHostHooks and JobQueues to Context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
thread_localcontexts to have ownedHostHooksandJobQueues.It changes the following:
MaybeSharedstruct that can hold either a reference or anRc.job_queueandhost_hooksparameters ofContextto useMaybeShared.This PR also allows us to make
SimpleJobQueuethe default promise runner, which I think it's pretty cool :)cc @lastmjs