Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Lift InternalObjectMethods from Object #2790

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Lift InternalObjectMethods from Object #2790

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5be4024
Lift `JsObject` internal methods from `Object`
jedel1043 Apr 6, 2023
ab8b674
Reword assert message
jedel1043 Apr 6, 2023
1072987
Fix docs
jedel1043 Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix docs
  • Loading branch information
@jedel1043
jedel1043 committed Apr 12, 2023
commit 107298745d9e1e118e2f745957cb46ab379fa343
2 changes: 1 addition & 1 deletion boa_engine/src/context/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ impl std::fmt::Debug for ContextBuilder<'_, '_, '_> {

impl<'icu, 'hooks, 'queue> ContextBuilder<'icu, 'hooks, 'queue> {
/// Creates a new [`ContextBuilder`] with a default empty [`Interner`]
/// and a default [`BoaProvider`] if the `intl` feature is enabled.
/// and a default `BoaProvider` if the `intl` feature is enabled.
#[must_use]
pub fn new() -> Self {
Self::default()
Expand Down
2 changes: 2 additions & 0 deletions boa_engine/src/object/builtins/jsfunction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ impl JsFunction {
/// Creates a new, empty intrinsic function object with only its function internal methods set.
///
/// Mainly used to initialize objects before a [`Context`] is available to do so.
///
/// [`Context`]: crate::Context
pub(crate) fn empty_intrinsic_function(constructor: bool) -> Self {
Self {
inner: JsObject::from_object_and_vtable(
Expand Down