Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add --strict flag to cli #2689

Closed
wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

This PR adds the --strict flag to the CLI that enables strict mode on file/interactive mode execution.

It's a bit annoying to have to prefix with 'use strict'; when trying to debug in interactive mode

>>> 'use strict'; .... // :(

It changes the following:

  • Adds --strict flag to CLI
  • update README.md

@HalidOdat HalidOdat added enhancement New feature or request cli Issues and PRs related to the Boa command line interface. labels Mar 18, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone Mar 18, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,277 94,277 0
Passed 70,720 70,720 0
Ignored 17,324 17,324 0
Failed 6,233 6,233 0
Panics 14 14 0
Conformance 75.01% 75.01% 0.00%

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #2689 (c614ba7) into main (b2b079b) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2689      +/-   ##
==========================================
- Coverage   49.31%   49.28%   -0.03%     
==========================================
  Files         395      397       +2     
  Lines       39649    39624      -25     
==========================================
- Hits        19553    19530      -23     
+ Misses      20096    20094       -2     
Impacted Files Coverage Δ
boa_cli/src/main.rs 0.00% <ø> (-0.90%) ⬇️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition!

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 18, 2023
This PR adds the `--strict` flag to the CLI that enables strict mode on file/interactive mode execution. 

It's a bit annoying to have to prefix with `'use strict';`  when trying to debug in interactive mode
```js
>>> 'use strict'; .... // :(
```

It changes the following:
- Adds `--strict` flag to CLI
- update `README.md`
@bors
Copy link

bors bot commented Mar 18, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add --strict flag to cli [Merged by Bors] - Add --strict flag to cli Mar 18, 2023
@bors bors bot closed this Mar 18, 2023
@bors bors bot deleted the feature/cli-strict-flag branch March 18, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Boa command line interface. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants