[Merged by Bors] - Align iterator loops to the spec #2686

jedel1043 · 2023-03-17T14:19:07Z

~~Depends on #2683.~~ Merged.

This Pull Request fixes #2658.

It changes the following:

Makes for .. of loop execution more spec compliant.
Rewrites iterator related opcodes to be able to use it on all for .. of/in loops.
Adds some utility op codes.

codecov · 2023-03-17T14:35:55Z

Codecov Report

Merging #2686 (766f809) into main (02f737a) will increase coverage by 0.99%.
The diff coverage is 60.45%.

@@            Coverage Diff             @@
##             main    #2686      +/-   ##
==========================================
+ Coverage   49.25%   50.24%   +0.99%     
==========================================
  Files         398      399       +1     
  Lines       39791    39839      +48     
==========================================
+ Hits        19599    20018     +419     
+ Misses      20192    19821     -371

Impacted Files	Coverage Δ
.../src/builtins/iterable/async_from_sync_iterator.rs	`4.61% <0.00%> (ø)`
boa_engine/src/value/mod.rs	`64.80% <ø> (-0.85%)`	⬇️
boa_engine/src/vm/code_block.rs	`43.98% <ø> (+14.41%)`	⬆️
boa_engine/src/vm/flowgraph/mod.rs	`0.00% <0.00%> (ø)`
boa_engine/src/vm/opcode/control_flow/throw.rs	`86.58% <0.00%> (-5.63%)`	⬇️
boa_engine/src/vm/opcode/iteration/get.rs	`100.00% <ø> (ø)`
boa_engine/src/vm/opcode/mod.rs	`45.45% <ø> (ø)`
boa_engine/src/vm/opcode/value/mod.rs	`37.50% <0.00%> (-12.50%)`	⬇️
boa_engine/src/vm/opcode/jump/mod.rs	`71.42% <16.66%> (+32.29%)`	⬆️
...rc/bytecompiler/declaration/declaration_pattern.rs	`29.01% <36.66%> (+2.80%)`	⬆️
... and 12 more

... and 19 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

HalidOdat

Looks good! :)

Just needs a rebase, and will be able to see what kind of change it has on the tests

boa_engine/src/vm/opcode/value/mod.rs

boa_engine/src/vm/opcode/generator/mod.rs

github-actions · 2023-03-18T09:12:29Z

Test262 conformance changes

Test result	main count	PR count	difference
Total	94,277	94,277	0
Passed	70,989	71,071	+82
Ignored	17,324	17,324	0
Failed	5,964	5,882	-82
Panics	14	14	0
Conformance	75.30%	75.39%	+0.09%

Fixed tests (82):

test/language/statements/class/async-gen-method/yield-spread-arr-single.js [strict mode] (previously Failed)
test/language/statements/class/async-gen-method/yield-spread-arr-single.js (previously Failed)
test/language/statements/class/async-gen-method/yield-spread-obj.js [strict mode] (previously Failed)
test/language/statements/class/async-gen-method/yield-spread-obj.js (previously Failed)
test/language/statements/class/async-gen-method/yield-spread-arr-multiple.js [strict mode] (previously Failed)
test/language/statements/class/async-gen-method/yield-spread-arr-multiple.js (previously Failed)
test/language/statements/class/elements/async-gen-private-method-static/yield-spread-arr-single.js [strict mode] (previously Failed)
test/language/statements/class/elements/async-gen-private-method-static/yield-spread-arr-single.js (previously Failed)
test/language/statements/class/elements/async-gen-private-method-static/yield-spread-obj.js [strict mode] (previously Failed)
test/language/statements/class/elements/async-gen-private-method-static/yield-spread-obj.js (previously Failed)
test/language/statements/class/elements/async-gen-private-method-static/yield-spread-arr-multiple.js [strict mode] (previously Failed)
test/language/statements/class/elements/async-gen-private-method-static/yield-spread-arr-multiple.js (previously Failed)
test/language/statements/class/elements/async-gen-private-method/yield-spread-arr-single.js [strict mode] (previously Failed)
test/language/statements/class/elements/async-gen-private-method/yield-spread-arr-single.js (previously Failed)
test/language/statements/class/elements/async-gen-private-method/yield-spread-obj.js [strict mode] (previously Failed)
test/language/statements/class/elements/async-gen-private-method/yield-spread-obj.js (previously Failed)
test/language/statements/class/elements/async-gen-private-method/yield-spread-arr-multiple.js [strict mode] (previously Failed)
test/language/statements/class/elements/async-gen-private-method/yield-spread-arr-multiple.js (previously Failed)
test/language/statements/class/async-gen-method-static/yield-spread-arr-single.js [strict mode] (previously Failed)
test/language/statements/class/async-gen-method-static/yield-spread-arr-single.js (previously Failed)
test/language/statements/class/async-gen-method-static/yield-spread-obj.js [strict mode] (previously Failed)
test/language/statements/class/async-gen-method-static/yield-spread-obj.js (previously Failed)
test/language/statements/class/async-gen-method-static/yield-spread-arr-multiple.js [strict mode] (previously Failed)
test/language/statements/class/async-gen-method-static/yield-spread-arr-multiple.js (previously Failed)
test/language/statements/async-generator/yield-spread-arr-single.js [strict mode] (previously Failed)
test/language/statements/async-generator/yield-spread-arr-single.js (previously Failed)
test/language/statements/async-generator/yield-identifier-non-strict.js (previously Failed)
test/language/statements/async-generator/yield-spread-obj.js [strict mode] (previously Failed)
test/language/statements/async-generator/yield-spread-obj.js (previously Failed)
test/language/statements/async-generator/yield-identifier-spread-non-strict.js (previously Failed)
test/language/statements/async-generator/yield-spread-arr-multiple.js [strict mode] (previously Failed)
test/language/statements/async-generator/yield-spread-arr-multiple.js (previously Failed)
test/language/expressions/class/async-gen-method/yield-spread-arr-single.js [strict mode] (previously Failed)
test/language/expressions/class/async-gen-method/yield-spread-arr-single.js (previously Failed)
test/language/expressions/class/async-gen-method/yield-spread-obj.js [strict mode] (previously Failed)
test/language/expressions/class/async-gen-method/yield-spread-obj.js (previously Failed)
test/language/expressions/class/async-gen-method/yield-spread-arr-multiple.js [strict mode] (previously Failed)
test/language/expressions/class/async-gen-method/yield-spread-arr-multiple.js (previously Failed)
test/language/expressions/class/elements/async-gen-private-method-static/yield-spread-arr-single.js [strict mode] (previously Failed)
test/language/expressions/class/elements/async-gen-private-method-static/yield-spread-arr-single.js (previously Failed)
test/language/expressions/class/elements/async-gen-private-method-static/yield-spread-obj.js [strict mode] (previously Failed)
test/language/expressions/class/elements/async-gen-private-method-static/yield-spread-obj.js (previously Failed)
test/language/expressions/class/elements/async-gen-private-method-static/yield-spread-arr-multiple.js [strict mode] (previously Failed)
test/language/expressions/class/elements/async-gen-private-method-static/yield-spread-arr-multiple.js (previously Failed)
test/language/expressions/class/elements/async-gen-private-method/yield-spread-arr-single.js [strict mode] (previously Failed)
test/language/expressions/class/elements/async-gen-private-method/yield-spread-arr-single.js (previously Failed)
test/language/expressions/class/elements/async-gen-private-method/yield-spread-obj.js [strict mode] (previously Failed)
test/language/expressions/class/elements/async-gen-private-method/yield-spread-obj.js (previously Failed)
test/language/expressions/class/elements/async-gen-private-method/yield-spread-arr-multiple.js [strict mode] (previously Failed)
test/language/expressions/class/elements/async-gen-private-method/yield-spread-arr-multiple.js (previously Failed)
test/language/expressions/class/async-gen-method-static/yield-spread-arr-single.js [strict mode] (previously Failed)
test/language/expressions/class/async-gen-method-static/yield-spread-arr-single.js (previously Failed)
test/language/expressions/class/async-gen-method-static/yield-spread-obj.js [strict mode] (previously Failed)
test/language/expressions/class/async-gen-method-static/yield-spread-obj.js (previously Failed)
test/language/expressions/class/async-gen-method-static/yield-spread-arr-multiple.js [strict mode] (previously Failed)
test/language/expressions/class/async-gen-method-static/yield-spread-arr-multiple.js (previously Failed)
test/language/expressions/object/method-definition/async-gen-yield-spread-arr-multiple.js [strict mode] (previously Failed)
test/language/expressions/object/method-definition/async-gen-yield-spread-arr-multiple.js (previously Failed)
test/language/expressions/object/method-definition/async-gen-yield-identifier-non-strict.js (previously Failed)
test/language/expressions/object/method-definition/async-gen-yield-spread-obj.js [strict mode] (previously Failed)
test/language/expressions/object/method-definition/async-gen-yield-spread-obj.js (previously Failed)
test/language/expressions/object/method-definition/async-gen-yield-identifier-spread-non-strict.js (previously Failed)
test/language/expressions/object/method-definition/async-gen-yield-spread-arr-single.js [strict mode] (previously Failed)
test/language/expressions/object/method-definition/async-gen-yield-spread-arr-single.js (previously Failed)
test/language/expressions/async-generator/named-yield-spread-arr-single.js [strict mode] (previously Failed)
test/language/expressions/async-generator/named-yield-spread-arr-single.js (previously Failed)
test/language/expressions/async-generator/yield-spread-arr-single.js [strict mode] (previously Failed)
test/language/expressions/async-generator/yield-spread-arr-single.js (previously Failed)
test/language/expressions/async-generator/yield-identifier-non-strict.js (previously Failed)
test/language/expressions/async-generator/expression-yield-as-operand.js [strict mode] (previously Failed)
test/language/expressions/async-generator/expression-yield-as-operand.js (previously Failed)
test/language/expressions/async-generator/named-yield-identifier-non-strict.js (previously Failed)
test/language/expressions/async-generator/named-yield-spread-obj.js [strict mode] (previously Failed)
test/language/expressions/async-generator/named-yield-spread-obj.js (previously Failed)
test/language/expressions/async-generator/yield-spread-obj.js [strict mode] (previously Failed)
test/language/expressions/async-generator/yield-spread-obj.js (previously Failed)
test/language/expressions/async-generator/yield-identifier-spread-non-strict.js (previously Failed)
test/language/expressions/async-generator/yield-spread-arr-multiple.js [strict mode] (previously Failed)
test/language/expressions/async-generator/yield-spread-arr-multiple.js (previously Failed)
test/language/expressions/async-generator/named-yield-identifier-spread-non-strict.js (previously Failed)
test/language/expressions/async-generator/named-yield-spread-arr-multiple.js [strict mode] (previously Failed)
test/language/expressions/async-generator/named-yield-spread-arr-multiple.js (previously Failed)

jedel1043 · 2023-03-18T17:58:02Z

Will add a test for this, because it seems there are still some bugs on the issue

jedel1043 · 2023-03-21T05:36:41Z

This is ready for reviews! There are still a lot of bugs in our implementation of generators, but this should at least improve the loops aspect of it.

HalidOdat

Looks good to me! 😄

raskad

Nice changes

raskad · 2023-03-21T16:52:25Z

bors r+

~Depends on #2683.~ Merged. This Pull Request fixes #2658. It changes the following: - Makes `for .. of` loop execution more spec compliant. - Rewrites iterator related opcodes to be able to use it on all for .. of/in loops. - Adds some utility op codes.

bors · 2023-03-21T17:03:26Z

Pull request successfully merged into main.

Build succeeded:

jedel1043 added execution Issues or PRs related to code execution vm Issues and PRs related to the Boa Virtual Machine. labels Mar 17, 2023

jedel1043 added this to the v0.17.0 milestone Mar 17, 2023

jedel1043 requested review from Razican, jasonwilliams, HalidOdat, RageKnify, raskad and nekevss March 17, 2023 14:19

HalidOdat reviewed Mar 18, 2023

View reviewed changes

boa_engine/src/vm/opcode/value/mod.rs Outdated Show resolved Hide resolved

boa_engine/src/vm/opcode/generator/mod.rs Outdated Show resolved Hide resolved

jedel1043 force-pushed the fix-2658 branch from 9a1e6c5 to b9e8a45 Compare March 18, 2023 09:05

jedel1043 added 6 commits March 20, 2023 22:51

Conform to the AsyncIterator API on for await .. of loops

7596678

Fix emerging bugs

ffb5528

Restructure iterator ops

fea4965

Apply review

7948232

Add test

2819830

Fix jump bug

7772f2c

jedel1043 force-pushed the fix-2658 branch from 7ccf1b6 to 7772f2c Compare March 21, 2023 04:53

Fix panics

766f809

jedel1043 requested a review from HalidOdat March 21, 2023 05:36

HalidOdat approved these changes Mar 21, 2023

View reviewed changes

raskad approved these changes Mar 21, 2023

View reviewed changes

bors bot changed the title ~~Align iterator loops to the spec~~ [Merged by Bors] - Align iterator loops to the spec Mar 21, 2023

bors bot closed this Mar 21, 2023

bors bot deleted the fix-2658 branch March 21, 2023 17:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - Align iterator loops to the spec #2686

[Merged by Bors] - Align iterator loops to the spec #2686

jedel1043 commented Mar 17, 2023 •

edited

Loading

codecov bot commented Mar 17, 2023 •

edited

Loading

HalidOdat left a comment

github-actions bot commented Mar 18, 2023 •

edited

Loading

jedel1043 commented Mar 18, 2023

jedel1043 commented Mar 21, 2023

HalidOdat left a comment

raskad left a comment

raskad commented Mar 21, 2023

bors bot commented Mar 21, 2023

[Merged by Bors] - Align iterator loops to the spec #2686

[Merged by Bors] - Align iterator loops to the spec #2686

Conversation

jedel1043 commented Mar 17, 2023 • edited Loading

codecov bot commented Mar 17, 2023 • edited Loading

Codecov Report

HalidOdat left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 18, 2023 • edited Loading

Test262 conformance changes

jedel1043 commented Mar 18, 2023

jedel1043 commented Mar 21, 2023

HalidOdat left a comment

Choose a reason for hiding this comment

raskad left a comment

Choose a reason for hiding this comment

raskad commented Mar 21, 2023

bors bot commented Mar 21, 2023

jedel1043 commented Mar 17, 2023 •

edited

Loading

codecov bot commented Mar 17, 2023 •

edited

Loading

github-actions bot commented Mar 18, 2023 •

edited

Loading