[Merged by Bors] - Optimize Get/SetPropertyByName

[tunz]

Similar to #2604, GetPropertyByName/SetPropertyByName has only string property key. So, we can skip index and utf16 conversions.

This improves QuickJS benchmark score 5.8% on average.
Richards: 37.0 -> 41.2
DeltaBlue: 38.1 -> 41.4
Crypto: 59.6 -> 59.8
RayTrace: 146 -> 159
EarleyBoyer: 138 -> 142
Splay: 104 -> 106
NavierStokes: 10.2 -> 10.3

[codecov]

Codecov Report

Merging #2608 (3d1b1c0) into main (310c671) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2608      +/-   ##
==========================================
+ Coverage   49.42%   49.61%   +0.19%     
==========================================
  Files         386      384       -2     
  Lines       39244    39082     -162     
==========================================
- Hits        19396    19391       -5     
+ Misses      19848    19691     -157     

Impacted Files	Coverage Δ
boa_engine/src/value/mod.rs	65.64% <100.00%> (ø)
boa_engine/src/vm/opcode/get/property.rs	65.62% <100.00%> (ø)
boa_engine/src/vm/opcode/set/property.rs	64.34% <100.00%> (-0.28%)	⬇️
boa_interner/src/lib.rs	82.35% <0.00%> (-1.69%)	⬇️
boa_engine/src/string/mod.rs	80.96% <0.00%> (-0.14%)	⬇️
boa_examples/src/bin/jsarray.rs
boa_examples/src/bin/closures.rs
boa_examples/src/bin/modulehandler.rs
boa_examples/src/bin/jsset.rs	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jedel1043]

Thanks! Also, I'm seeing that you do additional benchmarking on the engine for every one of your PRs. Would you be open to integrate that on our repo?

[raskad]

bors r+

[bors]

Build failed:

• Coverage

[raskad]

bors retry

[bors]

Pull request successfully merged into main.

Build succeeded:

• Build and Test (macos-latest)
• Build and Test (windows-latest)
• Coverage
• Misc

[tunz]

Thanks! Also, I'm seeing that you do additional benchmarking on the engine for every one of your PRs. Would you be open to integrate that on our repo?

yeah, it would be nice to have the benchmark in CI, or regular run on any pipeline here. But, I'm not familiar with how the CI works here and how I can test it. I simply downloaded the benchmark and combined the tests by running make after removing RegExp test which was not working with boa at the time.