Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update icu dependencies #2574

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Update icu dependencies #2574

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Jan 27, 2023

This Pull Request changes the following:

  • Update icu dependencies
  • Regenerate icu data

@raskad raskad added the rust Pull requests that update Rust code label Jan 27, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,205 94,205 0
Passed 70,686 70,690 +4
Ignored 18,622 18,622 0
Failed 4,897 4,893 -4
Panics 0 0 0
Conformance 75.03% 75.04% +0.00%
Fixed tests (6): 
test/intl402/Intl/getCanonicalLocales/error-cases.js [strict mode] (previously Failed)
test/intl402/Intl/getCanonicalLocales/error-cases.js (previously Failed)
test/intl402/Locale/constructor-unicode-ext-invalid.js [strict mode] (previously Failed)
test/intl402/Locale/constructor-unicode-ext-invalid.js (previously Failed)
test/intl402/Locale/constructor-options-numberingsystem-invalid.js [strict mode] (previously Failed)
test/intl402/Locale/constructor-options-numberingsystem-invalid.js (previously Failed)
Broken tests (2): 
test/intl402/Collator/usage-de.js [strict mode] (previously Passed)
test/intl402/Collator/usage-de.js (previously Passed)

@codecov
Copy link

codecov bot commented Jan 27, 2023 •
edited
Loading

Codecov Report

Merging #2574 (485c819) into main (e6a1c37) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2574      +/-   ##
==========================================
- Coverage   50.01%   50.01%   -0.01%     
==========================================
  Files         380      380              
  Lines       37786    37786              
==========================================
- Hits        18898    18897       -1     
- Misses      18888    18889       +1
Impacted Files Coverage Δ
boa_engine/src/object/mod.rs 45.84% <0.00%> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@raskad raskad added the dependencies Pull requests that update a dependency file label Jan 28, 2023
jedel1043
jedel1043 approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the failing tests are either a bug in ICU4X or a bug in our Collator implementation, so this can be merged as it is and I'll investigate that.

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 28, 2023
@raskad
Update icu dependencies (#2574)
aa8e0c5 
This Pull Request changes the following:

- Update icu dependencies
- Regenerate icu data
@bors
Copy link

bors bot commented Jan 28, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update icu dependencies [Merged by Bors] - Update icu dependencies Jan 28, 2023
@bors bors bot closed this Jan 28, 2023
@bors bors bot deleted the update-icu branch January 28, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@Razican Razican Awaiting requested review from Razican

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @jedel1043 @nekevss