-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix error for static class methods named prototype
#2552
Conversation
Test262 conformance changes
Fixed tests (16):
|
Codecov Report
@@ Coverage Diff @@
## main #2552 +/- ##
==========================================
- Coverage 49.99% 49.98% -0.01%
==========================================
Files 379 379
Lines 37642 37639 -3
==========================================
- Hits 18819 18814 -5
- Misses 18823 18825 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors r+ |
This Pull Request changes the following: - Remove wrong early errors for static class methods with the computed property name `prototype`. - Switch static class method definition opcodes from `__define_own_property__` to `define_property_or_throw` to correctly throw runtime errors on property redefinitions.
Pull request successfully merged into main. Build succeeded: |
prototype
prototype
This Pull Request changes the following:
prototype
.__define_own_property__
todefine_property_or_throw
to correctly throw runtime errors on property redefinitions.