-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Remove Literal::Undefined
#2518
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2518 +/- ##
=======================================
Coverage 51.58% 51.59%
=======================================
Files 356 355 -1
Lines 35666 35632 -34
=======================================
- Hits 18397 18383 -14
+ Misses 17269 17249 -20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
bors r+ |
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel necessary. ---> This Pull Request fixes/closes #2512 . Removes `Literal::Undefined` so that `undefined` is treated as an identifier name. Ran the parser's idempotency fuzzer and ensured the bug doesn't reproduce.
Pull request successfully merged into main. Build succeeded: |
Literal::Undefined
Literal::Undefined
This Pull Request fixes/closes #2512 .
Removes
Literal::Undefined
so thatundefined
is treated as an identifier name. Ran the parser's idempotency fuzzer and ensured the bug doesn't reproduce.