-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Pass a receiver value in property getter opcodes #2516
Conversation
Test262 conformance changes
Fixed tests (2):
|
Codecov Report
@@ Coverage Diff @@
## main #2516 +/- ##
==========================================
- Coverage 50.68% 50.60% -0.08%
==========================================
Files 358 359 +1
Lines 36265 36339 +74
==========================================
+ Hits 18380 18389 +9
- Misses 17885 17950 +65
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
bors r+ |
This Pull Request changes the following: - Pass a receiver value to the object `get` function in the `GetPropertyBy*` opcodes. The receiver value may be different from the object, because `ToObject` is not called on it.
Build failed: |
bors retry |
This Pull Request changes the following: - Pass a receiver value to the object `get` function in the `GetPropertyBy*` opcodes. The receiver value may be different from the object, because `ToObject` is not called on it.
Pull request successfully merged into main. Build succeeded: |
This Pull Request changes the following:
get
function in theGetPropertyBy*
opcodes. The receiver value may be different from the object, becauseToObject
is not called on it.