[Merged by Bors] - Cleanup Context APIs
#2504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Test262 conformance changes
|
|
Oof, the engine didn't like the adjustments I did to the |
Codecov Report
@@ Coverage Diff @@
## main #2504 +/- ##
==========================================
+ Coverage 51.27% 51.46% +0.18%
==========================================
Files 356 356
Lines 35864 35678 -186
==========================================
- Hits 18391 18361 -30
+ Misses 17473 17317 -156
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nekevss
reviewed
Dec 27, 2022
jedel1043
force-pushed
the
context-api
branch
from
a680d2d to
d45ed7d
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 27, 2022
Just a general cleanup of the APIs of our `Context`. - Reordered the `pub` and `pub(crate)/fn` methods to have a clear separation between our public and private APIs. - Removed the call method and added it to `JsValue` instead, which semantically makes a bit more sense. - Removed the `construct_object` method, and added an utility method `new` to `JsObject` instead. - Rewrote some patterns I found while rewriting the calls of the removed function.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Context APIsContext APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a general cleanup of the APIs of our
Context.pubandpub(crate)/fnmethods to have a clear separation between our public and private APIs.JsValueinstead, which semantically makes a bit more sense.construct_objectmethod, and added an utility methodnewtoJsObjectinstead.