Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - replace deprecated set-output command #2500

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - replace deprecated set-output command #2500

wants to merge 4 commits into from

Conversation

karol-janik
Copy link
Contributor

@karol-janik karol-janik commented Dec 20, 2022 •
edited
Loading

This Pull Request fixes/closes #2415.

It changes the following:

  • Replaced deprecated set-output command following GitHub guide

@karol-janik karol-janik mentioned this pull request Dec 20, 2022
Closed
@karol-janik karol-janik changed the title fix(ci): replace depricated set-output command replace depricated set-output command Dec 20, 2022
@karol-janik karol-janik changed the title replace depricated set-output command replace deprecated set-output command Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022 •
edited
Loading

Codecov Report

Merging #2500 (0fc6dda) into main (cc45a82) will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2500      +/-   ##
==========================================
+ Coverage   52.79%   52.97%   +0.18%     
==========================================
  Files         343      344       +1     
  Lines       34885    34756     -129     
==========================================
- Hits        18417    18412       -5     
+ Misses      16468    16344     -124
Impacted Files Coverage Δ
boa_interner/src/lib.rs 80.67% <0.00%> (-3.37%) ⬇️
boa_cli/src/main.rs 0.00% <0.00%> (-1.08%) ⬇️
boa_gc/src/cell.rs 63.84% <0.00%> (-0.57%) ⬇️
boa_cli/src/helper.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/commuter_visitor.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/classes.rs
boa_examples/src/bin/loadfile.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/jstypedarray.rs 0.00% <0.00%> (ø)
...arser/src/parser/expression/left_hand_side/call.rs 55.73% <0.00%> (+1.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jedel1043 jedel1043 added this to the v0.17.0 milestone Dec 20, 2022
@jedel1043 jedel1043 added the github_actions Pull requests that update Github_actions code label Dec 20, 2022
@jedel1043
Copy link
Member

New output:

Test262 conformance changes

| Test result | main count | PR count | difference |%0A| :---------: | :----------: | :------: | :--------: |%0A| Total | 94,172 | 94,172 | 0 |%0A| Passed | 69,656 | 69,656 | 0 |%0A| Ignored | 18,771 | 18,771 | 0 |%0A| Failed | 5,745 | 5,745 | 0 |%0A| Panics | 0 | 0 | 0 |%0A| Conformance | 73.97%25 | 73.97%25 | 0.00%25 |

jedel1043
jedel1043 requested changes Dec 20, 2022
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output seems to have replaced line feeds with the %0A escaped codepoint?

EDIT: Ah, probably because set-output required escaped codepoints, but the newer command does not. You'll need to remove those substitutions in the action also.

jedel1043
jedel1043 requested changes Dec 21, 2022
View reviewed changes
.github/workflows/test262.yml Outdated Show resolved Hide resolved
.github/workflows/test262.yml Outdated Show resolved Hide resolved
@jedel1043
Copy link
Member

Current output:

Test262 conformance changes

Test result main count PR count difference
Total 94,172 94,172 0
Passed 69,656 69,656 0
Ignored 18,771 18,771 0
Failed 5,745 5,745 0
Panics 0 0 0
Conformance 73.97% 73.97% 0.00%

jedel1043
jedel1043 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

HalidOdat
HalidOdat approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me! :)

@HalidOdat
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 27, 2022
@karol-janik
replace deprecated set-output command (#2500)
e707d87 
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel necessary.
--->

This Pull Request fixes/closes #2415.

It changes the following:

- Replaced deprecated set-output command following [GitHub guide](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/) 



Co-authored-by: karol-janik <karol.janik@wpengine.com>
@bors
Copy link

bors bot commented Dec 27, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title replace deprecated set-output command [Merged by Bors] - replace deprecated set-output command Dec 27, 2022
@bors bors bot closed this Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Awaiting requested review from Razican

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@nekevss nekevss Awaiting requested review from nekevss

@RageKnify RageKnify Awaiting requested review from RageKnify

@raskad raskad Awaiting requested review from raskad

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

Test262 action gives warnings in GitHub actions
3 participants
@karol-janik @jedel1043 @HalidOdat