-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Switch tarpaulin to llvm engine #2432
Conversation
Trying this to see if it makes coverage numbers more accurate
58979a5
to
1a6bb60
Compare
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2432 +/- ##
===========================================
+ Coverage 38.86% 52.03% +13.17%
===========================================
Files 316 320 +4
Lines 24123 34262 +10139
===========================================
+ Hits 9375 17829 +8454
- Misses 14748 16433 +1685
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Both engines seem to mostly suffer from false negatives, this engine seems to considers 10139 more lines. Looking at the codecov.io report the differences are a little weird so I'm not sure how to feel. |
After reading the relevant issue in I am in favor of switching. |
I agree with @raskad. The LLVM engine also has the advantage of having more support for other architectures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, switching seems like the right choice :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change :) tarpaulin is moving in the good direction here. If we find false positives/negatives, we should report them.
Bors r+ |
Trying this to see if it makes coverage numbers more accurate
Pull request successfully merged into main. Build succeeded: |
Trying this to see if it makes coverage numbers more accurate