[Merged by Bors] - Cleanup and speed-up CI #2376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2376 +/- ##
==========================================
- Coverage 40.03% 39.89% -0.14%
==========================================
Files 304 304
Lines 23401 23332 -69
==========================================
- Hits 9368 9308 -60
+ Misses 14033 14024 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Razican
reviewed
Oct 24, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Ah, you forgot to change the |
HalidOdat
approved these changes
Oct 24, 2022
|
Yeah, I still want to modify the bors action, I'll get to it today. |
This introduces multiple changes to our CI setup - Switch cache action to rust-cache, this handles which directories to cache for us - Switch to the nextest[2] test runner for Windows and MacOS - Join the smaller jobs into one bigger misc job that handles clippy, rustfmt, documentation and examples. This should still be faster than the linux job and should save some resources overall [1] - https://github.com/Swatinem/rust-cache [2] - https://nexte.st/
tarpaulin is very slow already, this should balance things out
This will make them have separate cache keys, meaning they don't share their target directory and each one stores and loads a smaller archive from the cache.
Simplified the name of the jobs in rust.yml Removed bors.yml, it was just copying rust.yml, instead this adds the staging and trying branches to the list of branches where the ci should run
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
Currently we run 7 different jobs: - tests linux - tests macos - tests windows - rustfmt - clippy - examples - documentation With this change I reduced them to 4 and hopefully sped them up. The total execution time is limited by the tests, especially linux that calculates coverage. Having separate jobs for clippy and rustfmt (which take a very small amount of time) is a waste of energy. With this PR: Introduced a new cargo profile, `ci`, that should create smaller sized binaries and reduce the our cache usage. I changed the test runner for macos and windows to [nextest](https://nexte.st/), which should be faster and is specifically designed for CI. I merged all smaller tasks in a single job, misc, the steps clearly identify what is being tested so it shouldn't affect clarity. Switched to using the [rust-cache](https://github.com/Swatinem/rust-cache) GH action, this simplifies our work by no longer having to worry about which directories to cache, rust-cache handles all that for us. ~~The bors task should also be modified, I'll get to it as soon as I have time. I believe it should be possible for us to have a single workflow described and have it both be the normal CI and the bors test.~~
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we run 7 different jobs:
With this change I reduced them to 4 and hopefully sped them up.
The total execution time is limited by the tests, especially linux that calculates coverage. Having separate jobs for clippy and rustfmt (which take a very small amount of time) is a waste of energy.
With this PR:
Introduced a new cargo profile,
ci, that should create smaller sized binaries and reduce the our cache usage.I changed the test runner for macos and windows to nextest, which should be faster and is specifically designed for CI.
I merged all smaller tasks in a single job, misc, the steps clearly identify what is being tested so it shouldn't affect clarity.
Switched to using the rust-cache GH action, this simplifies our work by no longer having to worry about which directories to cache, rust-cache handles all that for us.
The bors task should also be modified, I'll get to it as soon as I have time. I believe it should be possible for us to have a single workflow described and have it both be the normal CI and the bors test.